BUG: Missing symbol *lahrd in LAPACK *FIXED*

[zerothi]

The compilation of the LAPACK library does not include the *lahrd routines.

I have searched the log and the source tree for possible explanations for not adding it. To no avail.

Hence, I would consider it a bug to not have the source added to the library.

A simple patch as the attached would suffice to add the symbols to the library.

[Julien Langou]

Hi zerothi,

I think there is indeed a mistake.

We made some clean-up and removed all functionalities which were flagged as deprecated.

?LAHRD was flagged as deprecated since at least 2006. So about 10 years. This is a low level auxiliary subroutine that we do not expect many users to use. If a user uses ?LAHRD, he/she is strongly encouraged to use ?LAHR2 instead. If a user really needs ?LAHRD and thinks we made a mistake by flagging deprecated in 2006, this is fine and we are always happy to hear about this kind of things. For now, the routine has been removed on purpose from LAPACK.

There is a new compilation flag: make deprecated. If you type this, then this should add the deprecated to LAPACK.

There are two mistakes. I think. First ?LAHRD needs to be moved to the DEPRECATED folder. Second ?LAHRD needs to be added to the made deprecated flag. I need to double-check everything before pushing this changes to LAPACK. I think this is a mistake. It was correct to remove ?LAHRD from make. But then we forgot to move to deprecated.

The SVN log are copy-pasted below

Code: Select all

------------------------------------------------------------------------
r1575 | philippe.theveny | 2015-08-18 07:58:57 +0900 (Tue, 18 Aug 2015) | 7 lines

Moved deprecated SGVD routines into DEPRECATED directory.
Added a BUILD_DEPRECATED option for make and cmake, which build
deprecated routines into the LAPACK library (OFF by default).
This completes r1563.

TODO: document the BUILD_DEPRECATED option (i.e. update documentation).

------------------------------------------------------------------------
r1563 | philippe.theveny | 2015-08-06 17:01:56 -0600 (Thu, 06 Aug 2015) | 10 lines

Move all but one deprecated routines to a new separate directory.
They are compiled and included in the liblapack.a archive when
the MAKEDEPRECATED option in the make.inc file is set.

TODO: Add the corresponding behavior to the cmake files.

NOTE: The xGEQPF routines are deprecated but still used by some
non-deprecated routines. They have not been moved to the DEPRECATED
directory.

------------------------------------------------------------------------
r1562 | philippe.theveny | 2015-08-06 14:57:14 -0600 (Thu, 06 Aug 2015) | 4 lines

Remove deprecated xGEQPF from the test suite.

WARNING: xGEQPF is still used in xGGSVP routines.

------------------------------------------------------------------------
r1561 | philippe.theveny | 2015-08-06 11:56:35 -0600 (Thu, 06 Aug 2015) | 5 lines

Remove all but one deprecated routines from the test suite.

NOTE: The tests are renumbered in xDRVLS and xCHKTZ.
TODO: remove deprecated xGEQPF, when it is replaced by xGEQP3 in xGGSVP.



Julien

[zerothi]

Ok, no worries then. As I could not find any notes about lahrd being deprecated I suspected it was a "mistake".
I look forward to the patch of moving it to the DEP folder.

Thanks for the clarification!

PS. Have you considered moving development to github? In that way pull-requests could be more "flowable"

[Julien Langou]

The way we flag a routine as deprecated is that we write in the header file of the routine that the routine is deprecated. As far as LAHRD goes, it is written: This is an OBSOLETE auxiliary routine. This routine will be 'deprecated' in a future release. Please use the new routine DLAHR2 instead. So this is how we do it.

[zerothi]

Ah, ok. That was not clear to me Sorry

I just did a grep of lahrd in the log with no results..

[admin]

dlhard was forgotten in the DEPRECATED folder.
Fixed in revision 1593.
Thank you for reporting the issue.