The LAPACK forum has moved to https://github.com/Reference-LAPACK/lapack/discussions.

Bug in documentation of BLAS1 complex dot *FIXED*

Post here if you want to report a bug to the LAPACK team

Bug in documentation of BLAS1 complex dot *FIXED*

Postby zerothi » Tue Sep 01, 2015 5:20 pm

The documentation for the complex dot product codes is erroneous.

I here attach a patch which fixes the ambiguity and streamlines the documentation of the complex dot routines.
Attachments
czdotuc.txt
svn diff, patch file
(1.51 KiB) Downloaded 283 times
Last edited by zerothi on Fri Sep 18, 2015 8:24 am, edited 1 time in total.
zerothi
 
Posts: 16
Joined: Thu Apr 30, 2015 8:42 am

Re: Bug in documentation of BLAS1 complex dot

Postby admin » Wed Sep 02, 2015 12:54 am

Thank you
I will review your suggestion with the BLAS authors.
This documentation comes actually from the original codes.
There is a little history in those. We always have been hesitating to change them.
admin
Site Admin
 
Posts: 616
Joined: Wed Dec 08, 2004 7:07 pm

Re: Bug in documentation of BLAS1 complex dot

Postby zerothi » Wed Sep 02, 2015 2:43 am

Ok.

It is just when you visit http://www.netlib.org/lapack/explore-ht ... tc_8f.html
or the others it is "erroneous".

Thanks for your consideration.
zerothi
 
Posts: 16
Joined: Thu Apr 30, 2015 8:42 am

Re: Bug in documentation of BLAS1 complex dot

Postby Julien Langou » Wed Sep 02, 2015 11:02 pm

A good pointer for getting the functionality of the BLAS subroutines is: http://www.netlib.org/blas/blasqr.pdf
This said, there is no reason for the header of the subroutine to be somewhat more descriptive. Good point. And that way the doxygen documentation will be better as well.
I just committed some edits to the comments based along your suggestions. Thanks! Julien.

Code: Select all
Index: cdotc.f
===================================================================
--- cdotc.f   (revision 1579)
+++ cdotc.f   (working copy)
@@ -23,8 +23,9 @@
 *>
 *> \verbatim
 *>
-*>    forms the dot product of two vectors, conjugating the first
-*>    vector.
+*> CDOTC forms the dot product of two complex vectors
+*>      CDOTC = X^H * Y
+*>
 *> \endverbatim
 *
 *  Authors:
Index: cdotu.f
===================================================================
--- cdotu.f   (revision 1579)
+++ cdotu.f   (working copy)
@@ -23,7 +23,9 @@
 *>
 *> \verbatim
 *>
-*>    CDOTU forms the dot product of two vectors.
+*> CDOTU forms the dot product of two complex vectors
+*>      CDOTU = X^T * Y
+*>
 *> \endverbatim
 *
 *  Authors:
Index: zdotc.f
===================================================================
--- zdotc.f   (revision 1579)
+++ zdotc.f   (working copy)
@@ -23,7 +23,9 @@
 *>
 *> \verbatim
 *>
-*> ZDOTC forms the dot product of a vector.
+*> ZDOTC forms the dot product of two complex vectors
+*>      ZDOTC = X^H * Y
+*>
 *> \endverbatim
 *
 *  Authors:
Index: zdotu.f
===================================================================
--- zdotu.f   (revision 1579)
+++ zdotu.f   (working copy)
@@ -23,7 +23,9 @@
 *>
 *> \verbatim
 *>
-*>    ZDOTU forms the dot product of two vectors.
+*> ZDOTU forms the dot product of two complex vectors
+*>      ZDOTU = X^T * Y
+*>
 *> \endverbatim
 *
Julien Langou
 
Posts: 835
Joined: Thu Dec 09, 2004 12:32 pm
Location: Denver, CO, USA

Re: Bug in documentation of BLAS1 complex dot

Postby zerothi » Thu Sep 03, 2015 2:37 am

Great, thanks.
Your description is much better than my suggested edit.
Surely the row/column order should be noted. :)
zerothi
 
Posts: 16
Joined: Thu Apr 30, 2015 8:42 am


Return to Bug report

Who is online

Users browsing this forum: No registered users and 1 guest