The LAPACK forum has moved to https://github.com/Reference-LAPACK/lapack/discussions.

DGGBAL/BAK, ZGGBAL/BAK missing INT conversion

Post here if you want to report a bug to the LAPACK team

DGGBAL/BAK, ZGGBAL/BAK missing INT conversion

Postby int128 » Fri Nov 28, 2014 2:23 am

Hello,

I have been working on FORTRAN to C++ converter (yes, another one:)) using LAPACK as a test-bed.

I have found inconsistencies in style/syntax at some places.
Would appreciate if you would consider fixing it.

ZLARFT:
ZGEMM is not listed in EXTERNAL section (but extensively used in the code).

DLADIV:
This file has three different routines - DLADIV, DLADIV1, DLADIV2.

DLADIV2 has "if" in lower case:

Code: Select all
         if( BR.NE.ZERO ) THEN


DGGBAL/BAK, ZGGBAL/BAK:
There are few places in these routines where DOUBLE PRECISION variables are implicitly converted to INTEGER.

For example:

Code: Select all
 
         IR = LSCALE( I ) + SIGN( HALF, LSCALE( I ) )

         JC=RSCALE(I)+SIGN(HALF,RSCALE(I))

         K=RSCALE(I)

         K=LSCALE(I)


R/LSCALE(I) is double precision, IR, JC and K are integers.

For the sake of correct semantic and F77 rules we have to use INT to show conversion explicitly.
Also this would make conversion to other languages much easier.

Interestingly, only those routines are missing the INT.

All these changes are small - is there any way to participate in development, so that I can the (small) changes myself?
Somebody whom I can send patches directly?

Thank you in advance.
int128
 
Posts: 14
Joined: Mon Nov 12, 2012 10:04 pm
Location: Yokohama, Japan

Re: DGGBAL/BAK, ZGGBAL/BAK missing INT conversion

Postby Julien Langou » Mon Dec 01, 2014 1:16 am

Hi Pavel, thanks for the patch! (r1517). Cheers, Julien.
Julien Langou
 
Posts: 835
Joined: Thu Dec 09, 2004 12:32 pm
Location: Denver, CO, USA


Return to Bug report

Who is online

Users browsing this forum: No registered users and 1 guest